Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test Optimization #1253

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add Test Optimization #1253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0b080ee
Add orchestrion, api key is still missing...
tonyredondo Nov 20, 2024
086b9e2
fixes
tonyredondo Nov 20, 2024
1908ae7
fixes
tonyredondo Nov 20, 2024
0827685
fixes
tonyredondo Nov 20, 2024
ee95495
add vault
tonyredondo Nov 20, 2024
c481417
add api key to the github job
tonyredondo Nov 20, 2024
ec5ec77
Update .gitlab-ci.yml
tonyredondo Nov 26, 2024
d0573d0
Update build.yml
tonyredondo Nov 26, 2024
8103680
Update .gitlab-ci.yml
tonyredondo Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,16 @@ jobs:

- name: Build
run: go build ./...


- name: Install orchestrion
run: |
go install github.com/DataDog/orchestrion@v0.9.4
orchestrion pin

- name: Test
run: go test -v $(go list ./... | grep -v /integration-tests) # We do not run integration-tests here because they require more tooling (Pulumi, invoke, ..). They will be run in a dedicated job
run: orchestrion go test -v $(go list ./... | grep -v /integration-tests) # We do not run integration-tests here because they require more tooling (Pulumi, invoke, ..). They will be run in a dedicated job
env:
DD_CIVISIBILITY_ENABLED: true
DD_CIVISIBILITY_AGENTLESS_ENABLED: true
DD_ENV: ci
DD_API_KEY: ${{ secrets.DATADOG_API_KEY }}
7 changes: 7 additions & 0 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,13 @@ integration-testing:
- chmod 400 $E2E_PRIVATE_KEY_PATH
- ssh-add $E2E_PRIVATE_KEY_PATH
- pip install -r requirements.txt
- go install github.com/DataDog/orchestrion@v0.9.4
- orchestrion pin
Comment on lines +80 to +81
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💬 suggestion
Could move these to the Dockerfile that defines the test-infra runner image, at the root of this repo

- export DD_CIVISIBILITY_ENABLED=true
- export DD_CIVISIBILITY_AGENTLESS_ENABLED=true
- export DD_ENV=ci
- export DD_API_KEY=$(vault kv get -field=api_key kv/k8s/gitlab-runner/test-infra-definitions/dd-token)
- export GOFLAGS="${GOFLAGS} '-toolexec=orchestrion toolexec'"
script:
- |
if [ ! -f ./dist/main ]; then
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/DataDog/test-infra-definitions

go 1.22.5
go 1.22.8

require (
dario.cat/mergo v1.0.1
Expand Down