zstd.go: Set ZSTD_LEGACY_SUPPORT=4 to decompress legacy payloads #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compressed output format was finalized with zstd version 0.8. To support decompression of previous versions, set the macro ZSTD_LEGACY_SUPPORT=4, which matches the documented default for the zstd command line tool: https://github.com/facebook/zstd/blob/dev/programs/README.md This made the compiled library about 20 kiB larger, but will allow this to be used with really old zstd payloads. .circleci/config.yml: Do not test with different versions of this macro, since the tests now include a check that it can decompress old payloads.
evanj
force-pushed
the
evan.jones/zstd-legacy
branch
from
db5eada
to
49e3667
Compare
|
By default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compressed output format was finalized with zstd version 0.8. To
support decompression of previous versions, set the macro
ZSTD_LEGACY_SUPPORT=4, which matches the documented default for the
zstd command line tool:
https://github.com/facebook/zstd/blob/dev/programs/README.md
This made the compiled library about 20 kiB larger, but will allow
this to be used with really old zstd payloads.
.circleci/config.yml: Do not test with different versions of this
macro, since the tests now include a check that it can decompress
old payloads.