[fix] bug in how AVG is decomposed into measures #1299
Merged
+28
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
In calculating the COUNT, if we use COUNT(1), we will get the COUNT of another column, which may have a differet number of non-null values than the one we're interested in
anhqle
force-pushed
the
fix-pre-agg-count-bug
branch
from
61c232d to
dd54bc2
Compare
shangyian
approved these changes
Jan 31, 2025
This reverts commit f190125.
anhqle
force-pushed
the
fix-pre-agg-count-bug
branch
from
f7b8221 to
9363cf7
Compare
shangyian
force-pushed
the
fix-pre-agg-count-bug
branch
from
9363cf7 to
f7b8221
Compare
anhqle
force-pushed
the
fix-pre-agg-count-bug
branch
from
f7b8221 to
b0dfb17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
I edited
decompose_test.pymake checkpassesmake testshows 100% unit test coverageNote:
make checkpassed locally after making a bunch of small edits. I'm not sure why it's failing here, and why the changes need to be made to unrelated alembic files in the first place. Suggestions welcome!