Python client changes, more docs, fix pdm #490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes a number of minor changes to the python client as well as docs.
engine_name
andengine_version
defaults toNone
so the server default is used. I also moved allowed these to be set at client instantiation so users can set it once and have it consistently used through the session. (Users can still override the client setting on individual method calls)dj.data(metrics=[...], dimensions=[...], filters=[...])
Test Plan
pip installed the client and used it against a local DJ instance.
make check
passesmake test
shows 100% unit test coverageDeployment Plan
N/A