[Feature-1620][admin] Integrate Casdoor for SSO #2250
Conversation
add casdoor login support SSO This closes DataLinkDC#1620
|
@aiwenmo Excuse me, what is this question |
this is github action's problem, wait for a moment, fixing it. |
hi, @gaopeng666 ,thank you very much for your pr, please add postgre's ddl/dml and h2's ddl/dml |
Then please provide the design of the front-end page |
| @@ -109,6 +109,8 @@ public enum Status { | |||
| KICK_OUT(10024, "token has been kicked offline", "token 已被踢下线"), | |||
| TOKEN_FREEZED(10025, "token has been frozen", "token 已被冻结"), | |||
| NO_PREFIX(10026, "The token was not submitted according to the specified prefix", "未按照指定前缀提交 token"), | |||
| STATE_CODE_ERROR(10027, "state inconsistency or state and code not pair", "状态码前后不一致或状态码和code不匹配"), | |||
| CASDOOR_DEFAULT_TENANT_NOFOUND(10028, "The Casdoor default tenant does not exist", "casdoor默认租户不存在"), | |||
There was a problem hiding this comment.
Maybe better to remove Casdoor ? eg : The default tenant does not exist
Or use an existing USER_NOT_BINDING_TENANT instead
| @@ -1105,7 +1105,7 @@ CREATE TABLE `dinky_sys_login_log` ( | |||
| `id` int NOT NULL AUTO_INCREMENT COMMENT 'key', | |||
| `user_id` int NOT NULL COMMENT 'user id', | |||
| `username` varchar(60) COLLATE utf8mb4_general_ci NOT NULL COMMENT 'username', | |||
| `login_type` int NOT NULL COMMENT 'login type（0:LOCAL,1:LDAP）', | |||
| `login_type` int NOT NULL COMMENT 'login type（0:LOCAL,1:ldap,2:Casdoor）', | |||
There was a problem hiding this comment.
Does this mean that SSO login is a standalone login method and not a replacement for existing local logins？
There was a problem hiding this comment.
Login type Casdoor is special, I think oidc (oauth2) is better than casdoor,=.=
ok, i will add |
This closes #1620
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: