Stop using deprecated defaultOption method #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeroenDeDauw
force-pushed
the
defaultOption
branch
from
c12e838 to
6ee5851
Compare
Merged
codders
reviewed
Dec 10, 2024
| @@ -38,9 +38,8 @@ class GlobeCoordinateParser implements ValueParser { | |||
|
|
|||
| public function __construct( ?ParserOptions $options = null ) { | |||
| $this->options = $options ?: new ParserOptions(); | |||
There was a problem hiding this comment.
Why not:
$this->options = ($options ?: new ParserOptions())
->withDefaultOption(...)
->withDefaultOption(...);
There was a problem hiding this comment.
Also works, but I couldn't be bothered in this case
|
|
||
| public function __construct( ?ParserOptions $options = null ) { | ||
| $this->options = $options ?: new ParserOptions(); | ||
|
|
||
| $this->options->defaultOption( ValueParser::OPT_LANG, 'en' ); | ||
| $this->defaultOption( ValueParser::OPT_LANG, 'en' ); |
There was a problem hiding this comment.
What's the reason for preferring the private defaultOption method here to repeated calls to withDefaultOption? Is it a wish to avoid repeated re-allocation of the options object?
There was a problem hiding this comment.
It was the quickest fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build, because Psalm gets angry when you use deprecated methods.