Add withDefaultOption() to replace defaultOption()
#59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is pretty clearly a copy of FormatterOptionsTest: see
diff <(sed 's/formatter/parser/g; s/Formatter/Parser/g;' tests/ValueFormatters/FormatterOptionsTest.php) tests/ValueParsers/ParserOptionsTest.php
Rename one variable that had been missed so far, and smooth out a
difference that was introduced in 814035c.
Passing the same mutable options instance around all over the place, with various parts of the code adding different defaults to it, is a recipe for confusion and bugs. Discourage it by introducing a new method that has cloning built into its interface.
lucaswerkmeister
added a commit
that referenced
this pull request
Dec 6, 2022
The default of 1 (only HEAD, no parents) is not enough for Scrutinizer, it seems. Problem witnessed in #59.
|
CI should get fixed by #60. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the same mutable options instance around all over the place, with various parts of the code adding different defaults to it, is a recipe for confusion and bugs. Discourage it by introducing a new method that has cloning built into its interface.
Partially motivated by Construct parsers with a copy of ParserOptions.