Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix specs to account for trilogy #88

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Fix specs to account for trilogy #88

merged 3 commits into from
Oct 20, 2023

Conversation

petergoldstein
Copy link
Contributor

This PR gets the specs green w/trilogy.

Key changes are:

  1. Adds trilogy to the sample config
  2. Restricts testing of trilogy to ActiveRecord 7.1.0 or later
  3. Pulls load_schema out of the database_cleaner version of DatabaseHelper and adds :trilogy to the appropriate when clause. In theory database_cleaner could be updated here instead, but I was confused by the separation and frankly it seemed simpler to pull the whole thing into this gem.

This runs green on my fork.

Copy link
Member

@etagwerker etagwerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petergoldstein looks good, thanks!

@etagwerker etagwerker merged commit 7da2abe into DatabaseCleaner:main Oct 20, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants