allow 127.0.0.1 in DATABASE_URL

DatabaseCleaner · Apr 2, 2018 · 829befd · 829befd
1 parent 303cfc8
commit 829befd
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/database_cleaner/safeguard.rb b/lib/database_cleaner/safeguard.rb
@@ -15,6 +15,8 @@ def initialize(env)
     end
 
     class RemoteDatabaseUrl
+      LOCAL = %w(localhost 127.0.0.1)
+
       def run
         raise Error::RemoteDatabaseUrl if !skip? && given?
       end
@@ -26,7 +28,7 @@ def given?
         end
 
         def remote?(url)
-          url && !url.include?('localhost')
+          url && !LOCAL.any? { |str| url.include?(str) }
         end
 
         def skip?

diff --git a/spec/database_cleaner/safeguard_spec.rb b/spec/database_cleaner/safeguard_spec.rb
@@ -21,14 +21,22 @@ module DatabaseCleaner
         end
       end
 
-      describe 'to a local url' do
+      describe 'to a localhost url' do
         env DATABASE_URL: 'postgres://localhost'
 
         it 'does not raise' do
           expect { cleaner.start }.to_not raise_error
         end
       end
 
+      describe 'to a 127.0.0.1 url' do
+        env DATABASE_URL: 'postgres://127.0.0.1'
+
+        it 'does not raise' do
+          expect { cleaner.start }.to_not raise_error
+        end
+      end
+
       describe 'DATABASE_CLEANER_ALLOW_REMOTE_DATABASE_URL is set' do
         env DATABASE_CLEANER_ALLOW_REMOTE_DATABASE_URL: true