Skip to content

Commit

Permalink
selftests: fib_nexthop_multiprefix: fix cleanup() netns deletion
Browse files Browse the repository at this point in the history
During setup():
...
        for ns in h0 r1 h1 h2 h3
        do
                create_ns ${ns}
        done
...

while in cleanup():
...
        for n in h1 r1 h2 h3 h4
        do
                ip netns del ${n} 2>/dev/null
        done
...

and after removing the stderr redirection in cleanup():

$ sudo ./fib_nexthop_multiprefix.sh
...
TEST: IPv4: host 0 to host 3, mtu 1400                              [ OK ]
TEST: IPv6: host 0 to host 3, mtu 1400                              [ OK ]
Cannot remove namespace file "/run/netns/h4": No such file or directory
$ echo $?
1

and a non-zero return code, make kselftests fail (even if the test
itself is fine):

...
not ok 34 selftests: net: fib_nexthop_multiprefix.sh # exit=1
...

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
Reviewed-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
piso77 authored and davem330 committed Jul 14, 2020
1 parent ff021f2 commit 651149f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/testing/selftests/net/fib_nexthop_multiprefix.sh
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ setup()

cleanup()
{
for n in h1 r1 h2 h3 h4
for n in h0 r1 h1 h2 h3
do
ip netns del ${n} 2>/dev/null
done
Expand Down

0 comments on commit 651149f

Please sign in to comment.