Add aarch64-darwin to the system map for conda channels. Fix darwin manylinux logic. Fix deptree NoneType + NoneType #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazelweakly
commented
Feb 12, 2022
| @@ -45,13 +45,17 @@ def remove_circles_and_print(pkgs: Iterable[ResolvedPkg], nixpkgs: NixpkgsIndex) | |||
| indexed_pkgs = {p.name: p for p in sorted(pkgs, key=lambda p: p.name)} | |||
| roots: Iterable[ResolvedPkg] = sorted([p for p in pkgs if p.is_root], key=lambda p: p.name) | |||
|
|
|||
| def get_build_inputs(pkg: ResolvedPkg): | |||
There was a problem hiding this comment.
This was just the simplest possible abstraction of existing code that was already duplicating this logic in a few places. Some of the PRs open by @tomprince have a much more thorough reworking of this file, so I tried to only touch it the minimum required to fix the NoneType + NoneType error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some aarch64-darwin compatibility fixes that I ran into on our own code.
The deptree thing would result in an error like #396
Fixes #396
Let's see if this also fixes the odd conda errors in CI.