Remove pipenv from dependency extractor derivation #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes automatic dependency extraction from packages when the user asks for a python version that differs too much from the default python in nixpkgs (which pipenv was built with). Fixes DavHau#426.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[I don't see a way to adapt pipenv to the python version the user asked for, since some use of base_derivation is used by multiple python versions. Hence I think it's better to remove pipenv.]
This fixes automatic dependency extraction from packages when the user
asks for a python version that differs too much from the default python
in nixpkgs (which pipenv was built with).
Fixes #426.