Replace --suffix-each with multiple --suffix options #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornfor
referenced
this pull request
in NixOS/nixpkgs
May 6, 2022
A "python" made with the wrapper is likely to be used as a shebang. On macOS, this requires a binary rather than another shebang'd script.
Since NixOS/nixpkgs@7f802c7 using --suffix-each in makeWrapperArgs is no longer supported and breaks like this: $ nix-build ./any-mach-nix-env-with-latest-nixpkgs.nix [...] <stdin>: In function 'main': <stdin>:9:6: error: #error makeCWrapper: Unknown argument --suffix-each <stdin>:10:6: error: #error makeCWrapper: Unknown argument PATH <stdin>:11:6: error: #error makeCWrapper: Unknown argument : <stdin>:12:6: error: #error makeCWrapper: Unknown argument builder for '/nix/store/41713mrzrqlq12kgfgcx10wmdvmkfh7k-python3-3.9.12-env.drv' failed with exit code 1 So replace it with multiple --suffix args, which the new makeBinaryWrapper/makeCWrapper program supports (and is compatible with the old makeWrapper). Fixes DavHau#444.
bjornfor
force-pushed
the
adapt-to-make-binary-wrapper
branch
from
d38d5fb
to
afce970
Compare
|
I was experiencing this same error, and using this PR resolved it for me. |
|
Same here - I was experiencing this same error, and using this PR resolved it for me! Thx! |
|
It worked for me too. |
|
@DavHau: Hi, can you merge this please? (mach-nix is currently broken against nixpkgs master, this PR fixes it.) |
|
Also fixes for me. |
|
I was experiencing this same error. Using this PR solved the issue for me. |
|
@DavHau: Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
NixOS/nixpkgs@7f802c7
using --suffix-each in makeWrapperArgs is no longer supported and breaks
like this:
So replace it with multiple --suffix args, which the new
makeBinaryWrapper/makeCWrapper program supports (and is compatible with
the old makeWrapper).
Fixes #444.