Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Version packages #102

Merged
merged 1 commit into from
May 26, 2023
Merged

[Release] Version packages #102

merged 1 commit into from
May 26, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 12, 2022

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@davidevmod/focus-trap@1.0.0

Major Changes

Patch Changes

  • 2c17880 Thanks @DaviDevMod! - Remove possibility to provide escape as a function.

    It is unnecessary, as the user of the library can easily listen for Esc key presses by themselves.

    As a side note, the implementation of the previous behaviour was buggy.

  • d95f7df Thanks @DaviDevMod! - Fix logic to "normalise" returnFocus in normalise.ts

    The default document.activeElement was not given in case returnFocus was undefined or a string not corresponding to any ID in the DOM.
    It was given only when returnFocus === true.

  • fd6cf73 Thanks @DaviDevMod! - Fix algorithm to find a destination for the focus.

    When (during in the context of a Tab key press happening) event.target has a tab index of zero, the library should switch from looking for the next zero tabbable to look for a positive tabbable whenever event.target is or precedes/follows the first/last zero tabbable in the whole focus trap.

    Before the fix, the switch in search would have happened only if event.target was contained in or preceded/followed the first/last root in the focus-trap.

  • 2c5bd1c Thanks @DaviDevMod! - Remove custom type annotation for Array.prototype.findLast.

    It is now buit-in since TypeScript v5.0 (Add Array.prototype.findLast and Array.prototype.findLastIndex microsoft/TypeScript#48829 (comment)).

  • 0d154e8 Thanks @DaviDevMod! - Fix demolish logic in trap-actions.ts

    state.isBuilt was set to false before calling pause and the focus trap was therefore left up and running (while an error would be thrown, saying "Cannot pause inexistent trap" ).

  • 0d90cba Thanks @DaviDevMod! - Export types

  • 79b0e44 Thanks @DaviDevMod! - Fix inefficient code in destination.ts

demo@0.1.4

Patch Changes

@vercel
Copy link

vercel bot commented Nov 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
focus-trap-demo-q37s ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 8:22pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
focus-trap-demo ⬜️ Ignored (Inspect) Visit Preview May 11, 2023 8:22pm

@vercel vercel bot temporarily deployed to Preview – focus-trap-demo-q37s November 12, 2022 22:37 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo November 12, 2022 22:38 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo-q37s November 12, 2022 22:50 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo November 12, 2022 22:51 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo November 12, 2022 23:03 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo-q37s November 12, 2022 23:04 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo-q37s November 12, 2022 23:51 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo November 12, 2022 23:52 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo-q37s November 13, 2022 00:11 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo November 13, 2022 00:12 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo-q37s November 13, 2022 00:16 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo November 13, 2022 00:18 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo November 14, 2022 00:27 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo-q37s November 14, 2022 00:29 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo-q37s November 14, 2022 01:08 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo-q37s November 14, 2022 01:10 Inactive
@vercel vercel bot temporarily deployed to Preview – focus-trap-demo November 14, 2022 01:11 Inactive
@DaviDevMod DaviDevMod merged commit 9d1800a into main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant