Reimplement micromark helper filterByPredicate to do fewer array mani…

…pulations for a ~6-7% elapsed time reduction.
DavidAnson · Sep 3, 2023 · 6a2b867 · 6a2b867
1 parent 24c97a5
commit 6a2b867
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 18 deletions.
diff --git a/demo/markdownlint-browser.js b/demo/markdownlint-browser.js
@@ -1320,15 +1320,29 @@ function micromarkParse(markdown) {
  */
 function filterByPredicate(tokens, allowed, transformChildren) {
   var result = [];
-  var pending = _toConsumableArray(tokens);
-  var token = null;
-  while (token = pending.shift()) {
-    if (allowed(token)) {
-      result.push(token);
-    }
-    if (token.children.length > 0) {
-      var transformed = transformChildren ? transformChildren(token) : token.children;
-      pending.unshift.apply(pending, _toConsumableArray(transformed));
+  var queue = [{
+    "array": tokens,
+    "index": 0
+  }];
+  while (queue.length > 0) {
+    var current = queue[queue.length - 1];
+    var array = current.array,
+      index = current.index;
+    if (index < array.length) {
+      var token = array[current.index++];
+      if (allowed(token)) {
+        result.push(token);
+      }
+      var children = token.children;
+      if (children.length > 0) {
+        var transformed = transformChildren ? transformChildren(token) : children;
+        queue.push({
+          "array": transformed,
+          "index": 0
+        });
+      }
+    } else {
+      queue.pop();
     }
   }
   return result;

diff --git a/helpers/micromark.cjs b/helpers/micromark.cjs
@@ -213,16 +213,33 @@ function micromarkParse(
  */
 function filterByPredicate(tokens, allowed, transformChildren) {
   const result = [];
-  const pending = [ ...tokens ];
-  let token = null;
-  while ((token = pending.shift())) {
-    if (allowed(token)) {
-      result.push(token);
+  const queue = [
+    {
+      "array": tokens,
+      "index": 0
     }
-    if (token.children.length > 0) {
-      const transformed =
-        transformChildren ? transformChildren(token) : token.children;
-      pending.unshift(...transformed);
+  ];
+  while (queue.length > 0) {
+    const current = queue[queue.length - 1];
+    const { array, index } = current;
+    if (index < array.length) {
+      const token = array[current.index++];
+      if (allowed(token)) {
+        result.push(token);
+      }
+      const { children } = token;
+      if (children.length > 0) {
+        const transformed =
+          transformChildren ? transformChildren(token) : children;
+        queue.push(
+          {
+            "array": transformed,
+            "index": 0
+          }
+        );
+      }
+    } else {
+      queue.pop();
     }
   }
   return result;