-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group minor/patch Dependabot updates #1315
base: next
Are you sure you want to change the base?
Conversation
Thank you! I'm glad this capability exists, but I actually do appreciate that the current approach gives each dependency change its own PR and its own validation once accepted. It's a bit more work for me to accept things individually, but I'm OK with it and that's how I'm inclined to stay for now. |
That's fine, the other part of this, is that even though CI is free, this reduces the load and rebase churn |
It's a good point, but GitHub has never complained so far and I don't know how to tell Dependabot to split a PR if something fails. :) Something that feels wasteful for no reason is how the checks run twice sometimes because a) branch was pushed and b) PR was updated. I want each of these events to cause checks to run, but don't need duplicate checks when the same commit happens to tick both boxes. I haven't looked into this, but suspect there is a way to be more efficient. |
Seems kind of like the current way of giving it a mention:
I think you're OK for that case, as Dependabot Pushes aren't built https://github.com/DavidAnson/markdownlint/blob/b2305efafb034b1f328845aec9928b5363ffd646/.github/workflows/ci.yml Feel free to close this, but I'll keep it open for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
Major versions will still create individual PRs, but minor/patch ones are grouped together like canada-ca/ore-ero#1915