Lint visible documents on activation

[marcusrbrown]

Changes the extension activation to request linting of all visible documents, not just the active one.

I noticed a small bug while working on the extension where a visible but inactive Markdown file would not be linted until either:

1. A change was made to the document or it was saved.
2. The Output tab was focused. The assumption is that this causes the onDidChangeVisibleTextEditors event to fire.

[DavidAnson]

Please review 33c2e4a. I made that change back when I was occasionally getting "took too long to initialize" bugs. What eventually fixed that was bundling, so I'm open to undoing that optimization - especially in light of the bug you report. However, it looks like you change might be more simply implemented with a call to cleanLintVisibleFiles?

[marcusrbrown]

Thanks for the clarification. I didn't use cleanLintVisibleFiles because it calls didChangeVisibleTextEditors which uses lint instead of requestLint. Thinking about it, that isn't necessarily an optimization unless requestLint and suppressLint are modified to support multiple documents. That itself may be an over-optimization unless a lint is pending over multiple documents that are being closed or modified via a replace action?

Updated to use cleanLintVisibleFiles during activation.

[DavidAnson]

You make a great point. I definitely do not want to add a synchronous lint of N documents to the load path. But as you say, requestLint isn't set up for multiple simultaneous calls. What about just wrapping the new call in a setTimeout using the same delay value?

[marcusrbrown]

Updated to wrap the call to cleanLintVisibleFiles with setTimeout in d807440.

[DavidAnson]

Do we need a function that calls cLVF, or can we pass it directly by name?

[marcusrbrown]

Done in ba0da26.

It would be great to have a global ESLint rule similar to Lodash's no-extraneous-function-wrapping available.

[DavidAnson]

Nice!