Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow the user to access edgeloops #27

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

glitchland
Copy link

@glitchland glitchland commented Oct 17, 2019

Thank you for your awesome work on this library. I added a few changes that allow the user to also explicitly request an edgeloop cut at a specified coordinate. For example:

            List<Vector3> slicePoints = EzySlice.Slicer.EdgeLoop(source, cuttingPlane);

            if (slicePoints == null)
            {
                Debug.LogWarning("Slice did not produce loop!");
                return false;
            } 

            layersPointList.Add(slicePoints);

Let me know if this is something that you think would be worth it to add to ezy-slice main, otherwise I can maintain it in my fork. I can also make any changes required to make it suitable for main.

@DavidArayan
Copy link
Owner

Always great to see contributions coming in, thank you for that!

I'll do a quick test over the weekend and merge with master. Could you describe what the use-case of this change is? ie, what is an edgeloop cut? cheers!

@glitchland
Copy link
Author

glitchland commented Oct 18, 2019

Hiya @DavidArayan, sorry for the slow reply.

So my use case was kinda strange I guess, I needed to take a series of cross sections of a mesh using a plane to emulate a 3d printer. I used that to build an extruder. I made this GIF of the functionality (it takes a little while to start running):

https://i.imgur.com/b69bWUo.gif

This would have taken me a long time if it were not for your amazing library, so I wanted to PR my code in case my changes can help someone else out the same way you helped me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants