Skip to content

Commit

Permalink
Merge pull request NOAA-EMC#6 from DavidHuber-NOAA/intel2022_dh
Browse files Browse the repository at this point in the history
Update the S4 module and delete a TODO
  • Loading branch information
hu5970 authored May 10, 2023
2 parents 362c767 + 437d6fb commit 3fcb166
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 3 additions & 3 deletions modulefiles/gsi_s4.lua
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
help([[
]])

local hpc_ver=os.getenv("hpc_ver") or "1.1.0"
local hpc_intel_ver=os.getenv("hpc_intel_ver") or "18.0.4"
local hpc_impi_ver=os.getenv("hpc_impi_ver") or "18.0.4"
local hpc_ver=os.getenv("hpc_ver") or "1.2.0"
local hpc_intel_ver=os.getenv("hpc_intel_ver") or "2022.1"
local hpc_impi_ver=os.getenv("hpc_impi_ver") or "2022.1"
local miniconda_ver=os.getenv("miniconda_ver") or "3.8-s4"
local prod_util_ver=os.getenv("prod_util_ver") or "1.2.2"

Expand Down
1 change: 0 additions & 1 deletion src/gsi/genstats_gps.f90
Original file line number Diff line number Diff line change
Expand Up @@ -784,7 +784,6 @@ subroutine contents_netcdf_diag_
call screen_to_single_nc_diag_metadata("Errinv_Adjust",(gps_allptr%rdiag(15)) )
call screen_to_single_nc_diag_metadata("Errinv_Final",(gps_allptr%rdiag(16)) )
call screen_to_single_nc_diag_metadata("Observation",(gps_allptr%rdiag(17)) )
!TODO Verify that 'adjusted' is supposed to be the same as unadjusted
if(isnan(gps_allptr%rdiag(17)) .or. isnan(gps_allptr%rdiag(5))) then
call nc_diag_metadata("Obs_Minus_Forecast_adjusted", sngl(real(r_missing)))
call nc_diag_metadata("Obs_Minus_Forecast_unadjusted", sngl(real(r_missing)))
Expand Down

0 comments on commit 3fcb166

Please sign in to comment.