Fixed uninitialized status variable. NOAA-EMC#447

src/gsi/general_read_fv3atm.f90

@@ -221,11 +221,9 @@ subroutine general_read_fv3atm_nems(grd,sp_a,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'div',g_div ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_fv3atm_nems: ERROR'
-         write(6,*) 'cannot handle having both sf and div'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_fv3atm_nems: ERROR'
+      write(6,*) 'cannot handle having both sf and div'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    iredundant=0
@@ -234,11 +232,9 @@ subroutine general_read_fv3atm_nems(grd,sp_a,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'vor',g_vor ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_fv3atm_nems: ERROR'
-         write(6,*) 'cannot handle having both vp and vor'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_fv3atm_nems: ERROR'
+      write(6,*) 'cannot handle having both vp and vor'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    iredundant=0
@@ -247,14 +243,13 @@ subroutine general_read_fv3atm_nems(grd,sp_a,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'tv',g_tv  ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_fv3atm_nems: ERROR'
-         write(6,*) 'cannot handle having both t and tv'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_fv3atm_nems: ERROR'
+      write(6,*) 'cannot handle having both t and tv'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    istatus=0
+   istatus1=0
    call gsi_bundlegetpointer(gfs_bundle,'ps',g_ps  ,ier);istatus = istatus + ier
    call gsi_bundlegetpointer(gfs_bundle,'q' ,g_q   ,ier);istatus = istatus + ier
    call gsi_bundlegetpointer(gfs_bundle,'oz',g_oz  ,ier);istatus = istatus + ier
@@ -265,19 +260,15 @@ subroutine general_read_fv3atm_nems(grd,sp_a,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'qg',g_qg  ,ier);istatus1= istatus1+ ier
    call gsi_bundlegetpointer(gfs_bundle,'cf',g_cf  ,ier);istatus1= istatus1+ ier
    if ( istatus /= 0 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_fv3atm_nems: ERROR'
-         write(6,*) 'Missing some of the required fields'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_fv3atm_nems: ERROR'
+      write(6,*) 'Missing some of the required fields'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    if ( istatus1 /= 0 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_fv3atm_nems: ERROR'
-         write(6,*) 'Missing some of the required hydrometeor fields for imp_physics = ', imp_physics
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_fv3atm_nems: ERROR'
+      write(6,*) 'Missing some of the required hydrometeor fields for imp_physics = ', imp_physics
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
 

src/gsi/general_read_gfsatm.f90

@@ -558,11 +558,9 @@ subroutine general_read_gfsatm(grd,sp_a,sp_b,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'div',g_div ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm: ERROR'
-         write(6,*) 'cannot handle having both sf and div'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm: ERROR'
+      write(6,*) 'cannot handle having both sf and div'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    iredundant=0
@@ -571,11 +569,9 @@ subroutine general_read_gfsatm(grd,sp_a,sp_b,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'vor',g_vor ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm: ERROR'
-         write(6,*) 'cannot handle having both vp and vor'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm: ERROR'
+      write(6,*) 'cannot handle having both vp and vor'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    iredundant=0
@@ -584,11 +580,9 @@ subroutine general_read_gfsatm(grd,sp_a,sp_b,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'tv',g_tv  ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm: ERROR'
-         write(6,*) 'cannot handle having both t and tv'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm: ERROR'
+      write(6,*) 'cannot handle having both t and tv'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    istatus=0
@@ -597,11 +591,9 @@ subroutine general_read_gfsatm(grd,sp_a,sp_b,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'oz',g_oz  ,ier);istatus=istatus+ier
    call gsi_bundlegetpointer(gfs_bundle,'cw',g_cwmr,ier);istatus=istatus+ier
    if ( istatus /= 0 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm: ERROR'
-         write(6,*) 'Missing some of the required fields'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm: ERROR'
+      write(6,*) 'Missing some of the required fields'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    allocate(g_u(grd%lat2,grd%lon2,grd%nsig),g_v(grd%lat2,grd%lon2,grd%nsig))
@@ -1246,11 +1238,9 @@ subroutine general_read_gfsatm_nems(grd,sp_a,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'div',g_div ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm_nems: ERROR'
-         write(6,*) 'cannot handle having both sf and div'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm_nems: ERROR'
+      write(6,*) 'cannot handle having both sf and div'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    iredundant=0
@@ -1259,11 +1249,9 @@ subroutine general_read_gfsatm_nems(grd,sp_a,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'vor',g_vor ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm_nems: ERROR'
-         write(6,*) 'cannot handle having both vp and vor'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm_nems: ERROR'
+      write(6,*) 'cannot handle having both vp and vor'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    iredundant=0
@@ -1272,11 +1260,9 @@ subroutine general_read_gfsatm_nems(grd,sp_a,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'tv',g_tv  ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm_nems: ERROR'
-         write(6,*) 'cannot handle having both t and tv'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm_nems: ERROR'
+      write(6,*) 'cannot handle having both t and tv'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    istatus=0
@@ -1287,11 +1273,9 @@ subroutine general_read_gfsatm_nems(grd,sp_a,filename,uvflag,vordivflag,zflag, &
    if(has_cf) call gsi_bundlegetpointer(gfs_bundle,'cf',g_cf,  ier);istatus=istatus+ier
 
    if ( istatus /= 0 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm_nems: ERROR'
-         write(6,*) 'Missing some of the required fields'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm_nems: ERROR'
+      write(6,*) 'Missing some of the required fields'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    allocate(g_u(grd%lat2,grd%lon2,grd%nsig),g_v(grd%lat2,grd%lon2,grd%nsig))
@@ -2079,11 +2063,9 @@ subroutine general_read_gfsatm_nc(grd,sp_a,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'div',g_div ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm_nems: ERROR'
-         write(6,*) 'cannot handle having both sf and div'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm_nems: ERROR'
+      write(6,*) 'cannot handle having both sf and div'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    iredundant=0
@@ -2092,11 +2074,9 @@ subroutine general_read_gfsatm_nc(grd,sp_a,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'vor',g_vor ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm_nems: ERROR'
-         write(6,*) 'cannot handle having both vp and vor'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm_nems: ERROR'
+      write(6,*) 'cannot handle having both vp and vor'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    iredundant=0
@@ -2105,11 +2085,9 @@ subroutine general_read_gfsatm_nc(grd,sp_a,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'tv',g_tv  ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm_nems: ERROR'
-         write(6,*) 'cannot handle having both t and tv'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm_nems: ERROR'
+      write(6,*) 'cannot handle having both t and tv'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    istatus=0
@@ -2118,11 +2096,9 @@ subroutine general_read_gfsatm_nc(grd,sp_a,filename,uvflag,vordivflag,zflag, &
    call gsi_bundlegetpointer(gfs_bundle,'oz',g_oz  ,ier);istatus=istatus+ier
    call gsi_bundlegetpointer(gfs_bundle,'cw',g_cwmr,ier);istatus=istatus+ier
    if ( istatus /= 0 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm_nems: ERROR'
-         write(6,*) 'Missing some of the required fields'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm_nems: ERROR'
+      write(6,*) 'Missing some of the required fields'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    allocate(g_u(grd%lat2,grd%lon2,grd%nsig),g_v(grd%lat2,grd%lon2,grd%nsig))
@@ -2787,11 +2763,9 @@ subroutine general_read_gfsatm_allhydro_nc(grd,sp_a,filename,uvflag,vordivflag,z
    call gsi_bundlegetpointer(gfs_bundle,'div',g_div ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm_allhydro_nc: ERROR'
-         write(6,*) 'cannot handle having both sf and div'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm_allhydro_nc: ERROR'
+      write(6,*) 'cannot handle having both sf and div'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    iredundant=0
@@ -2800,11 +2774,9 @@ subroutine general_read_gfsatm_allhydro_nc(grd,sp_a,filename,uvflag,vordivflag,z
    call gsi_bundlegetpointer(gfs_bundle,'vor',g_vor ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm_allhydro_nc: ERROR'
-         write(6,*) 'cannot handle having both vp and vor'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm_allhydro_nc: ERROR'
+      write(6,*) 'cannot handle having both vp and vor'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    iredundant=0
@@ -2813,14 +2785,13 @@ subroutine general_read_gfsatm_allhydro_nc(grd,sp_a,filename,uvflag,vordivflag,z
    call gsi_bundlegetpointer(gfs_bundle,'tv',g_tv  ,ier)
    if ( ier == 0 ) iredundant = iredundant + 1
    if ( iredundant==2 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm_allhydro_nc: ERROR'
-         write(6,*) 'cannot handle having both t and tv'
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm_allhydro_nc: ERROR'
+      write(6,*) 'cannot handle having both t and tv'
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif
    istatus=0
+   istatus1=0
    call gsi_bundlegetpointer(gfs_bundle,'ps',g_ps  ,ier);istatus=istatus+ier
    call gsi_bundlegetpointer(gfs_bundle,'q' ,g_q   ,ier);istatus=istatus+ier
    call gsi_bundlegetpointer(gfs_bundle,'oz',g_oz  ,ier);istatus=istatus+ier
@@ -2832,11 +2803,9 @@ subroutine general_read_gfsatm_allhydro_nc(grd,sp_a,filename,uvflag,vordivflag,z
    call gsi_bundlegetpointer(gfs_bundle,'qg',g_qg  ,ier);istatus1=istatus1+ier
 !  call gsi_bundlegetpointer(gfs_bundle,'cf',g_cf  ,ier);istatus1=istatus1+ier
    if ( istatus1 /= 0 ) then
-      if ( mype == 0 ) then
-         write(6,*) 'general_read_gfsatm_allhydro_nc: ERROR'
-         write(6,*) 'Missing some of the required hydrometeor fields for imp_physics = ', imp_physics
-         write(6,*) 'Aborting ... '
-      endif
+      write(6,*) 'general_read_gfsatm_allhydro_nc: ERROR'
+      write(6,*) 'Missing some of the required hydrometeor fields for imp_physics = ', imp_physics
+      write(6,*) 'Aborting ... '
       call stop2(999)
    endif