test_util: Add test for get_dict_key_from_value
#438
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for the
get_dict_key_from_value
. It is written so it tests dicts with various different values, far more exotic than the couple of uses in the codebase that only testdict[str, str]
. Although we do test that case we also test cases with more exotic key types, to allow the test to give us more confidence in this function.I also updated the type hints in
get_dict_key_from_value
function itself, although they are mostlyAny
and basedPyright does not like theAny
type by default. Although in this case I think it makes sense, dicts can have pretty much any key and value, so it makes sense that we could give this function a dict ofAny
and so the value we're searching for (searchval
) as well could also beAny
.