Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pupgui2: Display install location combobox text in tooltip #451

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

sonic2kk
Copy link
Contributor

Adds a tooltip to the installation location dropdown comboInstallLocation on the Main Menu which displays the dropdown's text. This can be useful if the path in the dropdown text is long, usually for paths. Resizing the window to see the full path is awkward, and not possible in some scenarios (like in GameScope). Some paths are so long that they are truncated in the dropdown itself at the Main Window's default size.

Steam

Heroic

One thing not implemented here that might be cool to display is if the launcher path is custom. We could maybe add [CUSTOM] somewhere in the tooltip. But I think making it more obvious when a chosen launcher path is custom is a general enhancement for the future, so we could tackle it then.

@DavidoTek
Copy link
Owner

Thanks!

One thing not implemented here that might be cool to display is if the launcher path is custom. We could maybe add [CUSTOM] somewhere in the tooltip. But I think making it more obvious when a chosen launcher path is custom is a general enhancement for the future, so we could tackle it then.

Yeah, it would make sense to also display it in the combo box itself, not only in the tooltip.

@DavidoTek DavidoTek merged commit cca7846 into DavidoTek:main Sep 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants