fix: support MacOS/Windows in non-headless mode. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
feature: allow the client to set the user data directory
feat(config.Language): allow the user to overwrite system language
|
Hey man, sorry for the late review, but good work on this PR. I like how you kept the OS specific files lean, that is what I was looking for. Please fix the linting issues, other than that the code looks good |
|
Unfortunately I don't know what the linter wants...I spent 15 minutes trying to understand what it means |
|
It wants you to add white space. I'll fix them |
|
Looks good now, thanks for the work! |
Davincible
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the compilation issue on MacOS and potentially Windows with minimal invasion. It simply moves the ModifyCmdFunc option into a tag specific build(windows,linux,macos) file.
It does not provide support for MacOS and Windows in headless mode but it fails gracefully.
Further support for headless mode on Windows and MacOS can be added in the stub files (i.e. chrome_darwin).