-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for DataQuestReward quest #477
Conversation
- Goal can display a visible red dot on the map - Goal can have an item to take x times - Icon displayed for each item linked to step in the journal - When a step is completed, a nice message is displayed to the player
That looks exciting! 🥳
99% coexist! If there is a way to autoconvert that would be the 1% potentially. Okay, I am going to test it out. yay |
They can coexist, however with this PR I'm currently studying if DataQuestRewardQuest is not the same than DataQuest with questType=RewardQuest but with enhancements. If so the idea would be to improve the current DataQuest :) |
There are only two tasks open from my perspective:
The latter is important to me because you can't easily change table names after the fact and the names are currently a bit overloaded and hard to decipher ( After this I'd merge it even if it contains bugs. We can still change them after the fact and the same applies to the merging of DataQuests and RewardQuests (if possible). |
Ok I will review that points :) |
Ok the warnings are now fixed and I have renamed the table to "RewardQuest" and "CharacterXRewardQuest" |
The aim of this PR is to discuss about improvment to the current quest system. I don't know if both current DataQuest and new DataQuestRewardQuest must coexist or if one can replace the other.
With the new DataQuestReward quest we can have :
The DataQuestReward quest is coming from OnTheDOL fork reintegrated in original DOL. The details of a quest example is here : http://losojos-001-site1.btempurl.com/Guides/Quests/doltoolboxrewardquests
To test it :
Missing tables to create : sql files attached
table1.txt
table2.txt