Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for DataQuestReward quest #477

Merged
merged 6 commits into from
Oct 15, 2023

Conversation

DigitalBox98
Copy link
Contributor

@DigitalBox98 DigitalBox98 commented Oct 2, 2023

The aim of this PR is to discuss about improvment to the current quest system. I don't know if both current DataQuest and new DataQuestRewardQuest must coexist or if one can replace the other.

With the new DataQuestReward quest we can have :

  • Each goal to reach can display a visible red dot on the map
  • Each goal can have an item to take x times
  • An icon displayed in the quest journal for each item retrieved
  • When a step is completed, a nice message is displayed to the player

quest1
quest2

The DataQuestReward quest is coming from OnTheDOL fork reintegrated in original DOL. The details of a quest example is here : http://losojos-001-site1.btempurl.com/Guides/Quests/doltoolboxrewardquests

To test it :

Missing tables to create : sql files attached

table1.txt
table2.txt

- Goal can display a visible red dot on the map
- Goal can have an item to take x times
- Icon displayed for each item linked to step in the journal
- When a step is completed, a nice message is displayed to the player
@NetDwarf
Copy link
Contributor

NetDwarf commented Oct 3, 2023

That looks exciting! 🥳

The aim of this PR is to discuss about improvment to the current quest system. I don't know if both current DataQuest and new DataQuestRewardQuest must coexist or if one can replace the other.

99% coexist! If there is a way to autoconvert that would be the 1% potentially.

Okay, I am going to test it out. yay

@DigitalBox98
Copy link
Contributor Author

They can coexist, however with this PR I'm currently studying if DataQuestRewardQuest is not the same than DataQuest with questType=RewardQuest but with enhancements. If so the idea would be to improve the current DataQuest :)

@NetDwarf
Copy link
Contributor

There are only two tasks open from my perspective:

  1. Fix the warnings
  2. Better table names (i.e. RewardQuests and CharacterXRewardQuest)

The latter is important to me because you can't easily change table names after the fact and the names are currently a bit overloaded and hard to decipher (DataQuestRewardQuest and CharacterXDQRewardQ).

After this I'd merge it even if it contains bugs. We can still change them after the fact and the same applies to the merging of DataQuests and RewardQuests (if possible).

@DigitalBox98
Copy link
Contributor Author

Ok I will review that points :)

@DigitalBox98
Copy link
Contributor Author

Ok the warnings are now fixed and I have renamed the table to "RewardQuest" and "CharacterXRewardQuest"

@NetDwarf NetDwarf merged commit ea76cb2 into Dawn-of-Light:master Oct 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants