-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade add-on to Ember.js v5.4.0 #305
Conversation
b2160c9
to
11b21fc
Compare
1d3bb44
to
b82e8dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding your last commit running manually prettier, maybe in the future we should add some git hooks or something on CI to prevent merging if there are some prettier errors (would have expected them to be detected via the lint job but 🤷♂️)
58412f6
to
1d4c5e0
Compare
7eb00a1
to
a644eb6
Compare
New review requested: I applied another upgrade (v5.3.0 to v5.4.0)
a644eb6
to
2ddeee9
Compare
2ddeee9
to
d75b283
Compare
BREAKING CHANGE: upgrade add-on to Ember.js v5.4.0 - Now require Ember.js v4.8 or above - Now require Ember CLI v4.8 or above - Now require Node.js v18 or above
There were some warnings when running `npm publish --dry-run`: ``` ➜ npm publish --dry-run npm WARN publish npm auto-corrected some errors in your package.json when publishing. Please run "npm pkg fix" to address these errors. npm WARN publish errors corrected: npm WARN publish "repository" was changed from a string to an object npm WARN publish "repository.url" was normalized to "git+https://github.com/DazzlingFugu/ember-cli-embedded.git" npm notice ... logs ... ```
d75b283
to
3352f8a
Compare
PR initially created the 28 October 2023, after 2 weeks I am going to merge it soon. |
Breaking
Upgrade add-on to Ember.js v5.4.0 (#305)
Chore
Fully migrate add-on to TypeScript (#305)
The add-on is now 100% TypeScript-based as it was regenerated with the latest specification and the
--typescript
flag.--typescript
flag toapp
andaddon
blueprints ember-cli/ember-cli#9972which also means it does not rely on
ember-cli-typescript
anymore:--typescript
support in blueprints ember-cli/ember-cli#10283Build
Dependencies updates (#305)
Added
@babel/core@^7.23.2
@glint/environment-ember-loose@^1.2.1
@glint/template@^1.2.1
broccoli-asset-rev@^3.0.0
concurrently@^8.2.2
ember-cli-inject-live-reload@^2.1.0
ember-cli-sri@^2.1.1
eslint-config-prettier@^9.0.0
eslint-plugin-n@^16.2.0
eslint-plugin-prettier@^5.0.1
prettier@^3.0.3
rimraf@^5.0.1
ember-source >= 4.0.0
is now a peer dependencyUpdated
ember-cli-babel@^8.2.0
ember-cli-htmlbars@^6.3.0
@ember/test-helpers@^3.2.0
@typescript-eslint/eslint-plugin@^6.9.1
@typescript-eslint/parser@^6.9.1
ember-auto-import@^2.6.3
ember-cli@~5.4.0
ember-cli-dependency-checker@^3.3.2
ember-qunit@^8.0.1
ember-source@~5.4.0
ember-try@^3.0.0
eslint@^8.52.0
eslint-plugin-ember@^11.11.1
eslint-plugin-qunit@^8.0.1
qunit@^2.20.0
typescript@^5.2.2
webpack@^5.89.0
Removed
ember-cli-typescript@^5.2.1
babel-eslint@^10.1.0
ember-cli-typescript-blueprints@^3.0.0
ember-disable-prototype-extensions@^1.1.3
ember-template-lint@^5.7.2
eslint-plugin-node@^11.1.0
npm-run-all@^4.1.5
Supersedes and closes #286 .
Below is just extra text to give more context, but it should not be included in our changelog.
Actions taken
--typescript
(using this brings additional changes compared to a simpleember new MyAddon
)Note to reviewers
When working on this I noticed we had some files that had extra whitespaces:
We are in 2023 we should not encounter such situations anymore, modern tools should take care of this.
Please configure your editor accordingly.
For instance with VSCode you need to enable this setting: