Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DELIMITER handling #10

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Fix DELIMITER handling #10

merged 2 commits into from
Mar 15, 2024

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Mar 5, 2024

Checklist

  • I have read the Contributing Guide
  • I have checked to ensure this does not introduce an unintended breaking changes
  • I have considered appropriate testing for my change

Description

Fixes #7
Extracted from DbUp/DbUp#661

Needs:

@epenet epenet marked this pull request as draft March 5, 2024 11:02
@epenet epenet marked this pull request as ready for review March 15, 2024 07:07
@epenet
Copy link
Contributor Author

epenet commented Mar 15, 2024

@droyad, from what I can work out, the CI is failing from something outside of this PR.

An issue pushing to GitHub packages:
warn : Your request could not be authenticated by the GitHub Packages service. Please ensure your access token is valid and has the appropriate scopes configured.

and an issue reporting on the test results
Error: HttpError: Resource not accessible by integration

@droyad
Copy link
Member

droyad commented Mar 15, 2024

@epenet Thanks for having a look. Not sure what's going on, I'm still messing around with the builds at the moment..

Builds and tests pass, so might as well merge it.

@droyad droyad merged commit d0130b5 into DbUp:main Mar 15, 2024
1 check failed
@epenet epenet deleted the 20240305-1155 branch March 15, 2024 11:48
@epenet
Copy link
Contributor Author

epenet commented Mar 15, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbup-mysql not handling 'delimiter' correctly
2 participants