Added support for supplying a custom CertificateValidationCallback #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Our use case I'm trying to solve with this PR is that we need to implement custom Server Certificate validation in our code base.
We already do this succesfully on all outgoing connections (both http and npgsql), but weren't able to with DbUp because the package only allows use to supply a connection string. We need to attach a handler on the created NpgsqlConnection object.
This PR adds an optional options object two the Extension methods with which you can supply a validation callback handler. Also, the existing option to supply a client certificate is supported. Existing APIs won't break, I've only added new methods.
Please let me know what you think.