Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #680 PostgreSQL statements split implemented #19

Merged

Conversation

campbellhardingdeason
Copy link

@campbellhardingdeason campbellhardingdeason commented Aug 1, 2024

Checklist

  • I have read the Contributing Guide
  • I have checked to ensure this does not introduce an unintended breaking changes
  • I have considered appropriate testing for my change

Description

Copied from @shokurov's PR here: DbUp/DbUp#750

Fixes #10

Co-authored-by: shokurov <egor.shokurov@gmail.com>
@droyad droyad changed the base branch from main to release/6.0.0 August 1, 2024 23:02
@droyad
Copy link
Member

droyad commented Aug 1, 2024

From what I can see this is a change in behaviour (for the better). Putting this into the upcoming v6 release. We'll publish a beta of the provider once this merges that includes this change so it can be tried out.

Copy link

@shokurov shokurov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be accurate copy of DbUp/DbUp#750

droyad
droyad previously approved these changes Dec 10, 2024
# Conflicts:
#	src/Tests/ApprovalFiles/NoPublicApiChanges.Run.approved.cs
@droyad droyad merged commit 80c9a50 into DbUp:release/6.0.0 Dec 10, 2024
1 check passed
@webcoyote
Copy link

I'm surprised that both this PR #680 and DbUp/DbUp#750 do not include an acknowledgement of authorship.

The SQL splitter code comes from the npgsql project.

That's why why my PR (DbUp/DbUp#673, which both #680 and #750 are derived from) includes the npgsql license file, as legally required by the npgsql project.

@droyad
Copy link
Member

droyad commented Dec 11, 2024

@webcoyote Yes, you are right. #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL 14.7, 11.19 incompatibility "CREATE INDEX CONCURRENTLY cannot be executed within a pipeline"
4 participants