Make it possible to change the master database name #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
I had to run a DbUp migration with a hosted PostgreSQL database at a cloud provider.
Their setup does not provide a database named
postgreswhich DbUp requires.In this change, I introduced a public static property named
MasterDatabaseNamewhich has the default valuepostgres. If the user does not set it explicitly, nothing changes. In my case, I could just set it to the name of an existing db name (which isdefaultdbin my case).References:
I saw that there was a similar PR two yeary ago:
EnsureDatabase.For: Fixed issue when postres database name is always 'postgres' DbUp#605
This approach did not work out because people relied on havinig DbUp set the master db name. My PR should bring together the best of both worlds and therefore make DbUp usable with a wider variety of hosted PG variations.
This change would also fix EnsureDatabase.For.PostgresqlDatabase doesn't work if database account cannot access postgres database #20