fix(ui-ux): fix displayed amount in transaction list #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lykalabrada
requested review from
thedoublejay,
kyleleow,
pierregee and
fullstackninja864
as code owners
DFC-398 Task: Fix displayed DFI amount from transactions list
Amount displayed on Transactions list doesnt match the amount inside tx details page (see image) |
✅ Deploy Preview for defimetascan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -53,7 +42,7 @@ export const transformTransactionData = (tx: RawTransactionI): TransactionI => { | |||
| transactionType, | |||
| type: tx.type, | |||
| hash: tx.hash, | |||
| amount: dfiAmount, | |||
| amount: formatEther(BigInt(tx.value ?? "0")), | |||
There was a problem hiding this comment.
for diff coin decimal value will be different, I guess we should get decimal value and then format
There was a problem hiding this comment.
this amount is only for "DFI value" so should always 18 decimals
fullstackninja864
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) does this PR fixes?:
Fixes DFC-398
Additional comments?:
Developer Checklist: