Update FindQueryBuilder.js #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DanAlexandruNiculescu
commented
Jul 26, 2022
DanAlexandruNiculescu
commented
- GroupBy key column added as a default
- GroupBy parameter is added only if there are joins
- GroupBy key column added as a default - GroupBy parameter is added only if there are joins
DeanMauro
reviewed
Jul 26, 2022
lib/FindQueryBuilder.js
Outdated
| if (groupByParam) { | ||
| builder.select(groupByParam.value.split(',')); | ||
| const joinParam = _.find(builder._operations, { name: 'innerJoin' }); | ||
| const keyColumn = this._modelClass.keyColumn; |
There was a problem hiding this comment.
What is keyColumn in this context?
DeanMauro
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.