-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add OP_CHECKCOLDSTAKEVERIFY_LOF #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterL73
force-pushed
the
checkcoldstakeverify
branch
from
October 31, 2022 10:21
b66b1ca
to
70b81a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Could this be related to or even fix #8 ?
Only opcode OP_CHECKCOLDSTAKEVERIFY is used to identify Cold Staking Contracts.
And opcode OP_CHECKCOLDSTAKEVERIFY [0xd1] differs from PIVX [0xd2]
PIVX changed the name of opcode OP_CHECKCOLDSTAKEVERIFY to OP_CHECKCOLDSTAKEVERIFY_LOF
And added a new opcode OP_CHECKCOLDSTAKEVERIFY [0xd2]
PIVX-Project/PIVX#2275
What was done?
Change opcode OP_CHECKCOLDSTAKEVERIFY to OP_CHECKCOLDSTAKEVERIFY_LOF
Add opcode OP_CHECKCOLDSTAKEVERIFY [0xd2]
Use both opcodes to check if it is a Pay to ColdStake Script
How Has This Been Tested?
It has not been tested. I could not get the go compiler working on my machine (yet), but could not wait to share.Breaking Changes
Checklist: