Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing tuple of [low, high] to iou_thresholds parameter in DetectionMetrics. #1223

Merged
merged 3 commits into from
Jun 28, 2023
Merged

Allow passing tuple of [low, high] to iou_thresholds parameter in DetectionMetrics. #1223

merged 3 commits into from
Jun 28, 2023

Conversation

BloodAxe
Copy link
Contributor

This PR allows to pass user-defined target of IoU thresholds without asking user to edit IoUThresholds enum in SG codebase:

valid_metrics_list:
  - DetectionMetrics:
      iou_thres: [0.5, 0.8]

Note that this does not solve the problem of having two instances of DetectionMetrics in valid_metrics_list, but it allow to pass iou_thres as a tuple which we do not allow at the moment

Louis-Dupont
Louis-Dupont approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@Louis-Dupont Louis-Dupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BloodAxe BloodAxe merged commit 1889bc8 into master Jun 28, 2023
@BloodAxe BloodAxe deleted the feature/SG-000-allow-tuple-range-mAP-metric branch June 28, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Louis-Dupont Louis-Dupont Louis-Dupont approved these changes

@shaydeci shaydeci Awaiting requested review from shaydeci

@ofrimasad ofrimasad Awaiting requested review from ofrimasad ofrimasad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BloodAxe @Louis-Dupont