Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array2D conformance to Swift.Collection #688

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vkondrashkov
Copy link

Feature proposal

I want to suggest you to extend Array2D with Swift.Collection to make it possible to use this collection in enhanced methods of CollectionViews

Alternatives

Make own Swift.Collection and conform it to QueryableSectionedDataSourceProtocol and SectionedDataSourceChangesetConvertible protocols.

Motivation

I have faced with this problem at my project, when I needed to implement sectioned table view with unique cells. It's possible to solve this problem with method bind(to:animated:rowAnimation:createCell:), but only SectionedDataSourceChangesetConvertible collections are able to bind table view in such way. And framework have such one: Swift.Array. Its problem is QueryableSectionedDataSourceProtocol conformance, where it returns numberOfSections equal to 1.

For this issue very convenient to use Array2D, but it can't conform to SectionedDataSourceChangesetConvertible due to it's not a Swift.Collection

As a result I have created this pull request.

Additional

Documentation or tests can be appended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant