Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DVISA-2573: async methods for color image pixel data transformation #15

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

aminahasimbegovic
Copy link
Collaborator

Added async/await to he methods that convert the pixel data of the color images.

The methods take some time, so the code that was executed after them was not working with the converted pixel data.

@aminahasimbegovic aminahasimbegovic changed the title Feature/dvisa 2573 black us DVISA-2573: async methods for color image pixel data transformation Jan 10, 2025
Copy link

gitstream-cm bot commented Jan 10, 2025

🥷 Code experts: no user but you matched threshold 10

See details

packages/dicomImageLoader/package.json

Knowledge based on git-blame:

packages/dicomImageLoader/src/imageLoader/colorSpaceConverters/convertPALETTECOLOR.ts

Knowledge based on git-blame:

packages/dicomImageLoader/src/imageLoader/colorSpaceConverters/convertRGBColorByPixel.ts

Knowledge based on git-blame:

packages/dicomImageLoader/src/imageLoader/colorSpaceConverters/convertRGBColorByPlane.ts

Knowledge based on git-blame:

packages/dicomImageLoader/src/imageLoader/colorSpaceConverters/convertYBRFull422ByPixel.ts

Knowledge based on git-blame:

packages/dicomImageLoader/src/imageLoader/colorSpaceConverters/convertYBRFullByPixel.ts

Knowledge based on git-blame:

packages/dicomImageLoader/src/imageLoader/colorSpaceConverters/convertYBRFullByPlane.ts

Knowledge based on git-blame:

packages/dicomImageLoader/src/imageLoader/convertColorSpace.ts

Knowledge based on git-blame:

packages/dicomImageLoader/src/imageLoader/createImage.ts

Knowledge based on git-blame:

To learn more about /:\ gitStream - Visit our Docs

Copy link

@muellnerlisa muellnerlisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Looks good to me :)

Copy link

@p1p3 p1p3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick and easy! Nice job!

@aminahasimbegovic aminahasimbegovic merged commit cb44a80 into main Jan 13, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants