Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new command: "Efficiency" #346

Merged
merged 5 commits into from
Nov 16, 2023

Conversation

MVladislav
Copy link
Contributor

Add new command: "Efficiency"

See more general info and details under discussion.

Ecovacs Home App Home Assistant
setEfficiency setEfficiency_home

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0c8565) 78.53% compared to head (d61a798) 78.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #346      +/-   ##
==========================================
+ Coverage   78.53%   78.81%   +0.27%     
==========================================
  Files          59       61       +2     
  Lines        2502     2535      +33     
  Branches      461      464       +3     
==========================================
+ Hits         1965     1998      +33     
  Misses        494      494              
  Partials       43       43              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add tests for the new commands?

deebot_client/commands/json/efficiency.py Outdated Show resolved Hide resolved
deebot_client/commands/json/efficiency.py Outdated Show resolved Hide resolved
deebot_client/commands/json/efficiency.py Outdated Show resolved Hide resolved
@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Nov 16, 2023
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MVladislav 👍

@edenhaus edenhaus merged commit 19a9684 into DeebotUniverse:dev Nov 16, 2023
6 checks passed
@MVladislav MVladislav deleted the feature/CommandEfficiency branch November 16, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new-feature PR, which adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants