Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Ota" commands #348

Merged
merged 15 commits into from
Feb 15, 2024
Merged

Add "Ota" commands #348

merged 15 commits into from
Feb 15, 2024

Conversation

MVladislav
Copy link
Contributor

@MVladislav MVladislav commented Nov 15, 2023 •
edited by edenhaus
Loading

Add new command: "Ota"

See more general info and details under discussion.

Ecovacs Home App Home Assistant
setOta setOta_home

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f75ebf) 82.72% compared to head (0dab410) 83.30%.
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #348      +/-   ##
==========================================
+ Coverage   82.72%   83.30%   +0.57%     
==========================================
  Files          72       74       +2     
  Lines        2895     2977      +82     
  Branches      515      531      +16     
==========================================
+ Hits         2395     2480      +85     
+ Misses        450      443       -7     
- Partials       50       54       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edenhaus edenhaus added the pr: new-feature PR, which adds a new feature label Nov 16, 2023
@edenhaus edenhaus changed the title Add new command: "ota" Add new command: "Ota" Nov 16, 2023
@MVladislav
merge: remote-tracking branch 'upstream/dev' into feature/CommandOta
1189b75
@MVladislav
refactor: extend ota with additional information + small improve
04afcd1 
- new added information: `support_auto`, `version`, `status`, `progress`
- capability update for only get information without set option
- update yna5xi for get ota information
@MVladislav
refactor: add missing test case update for ota event in yna5xi
31f1119
edenhaus
edenhaus requested changes Feb 11, 2024
View reviewed changes
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does there exists also a onOta message/event?

deebot_client/commands/json/ota.py Outdated Show resolved Hide resolved
deebot_client/commands/json/ota.py Outdated Show resolved Hide resolved
@MVladislav
refactor: small ota improves
029a7d5 
- for old bots set autoSwitch default to false
- improve set with correct/cleaner vars
@edenhaus
Copy link
Contributor

We need here also to split OnOta and GetOta if we are expecting events on atr

@MVladislav
Copy link
Contributor Author

We need here also to split OnOta and GetOta if we are expecting events on atr

saw only get and set

edenhaus
edenhaus requested changes Feb 15, 2024
View reviewed changes
deebot_client/commands/json/ota.py Outdated Show resolved Hide resolved
deebot_client/events/__init__.py Outdated Show resolved Hide resolved
@edenhaus edenhaus changed the title Add new command: "Ota" Add "Ota" commands Feb 15, 2024
@edenhaus edenhaus merged commit 8ac8c7b into DeebotUniverse:dev Feb 15, 2024
9 checks passed
@MVladislav MVladislav deleted the feature/CommandOta branch February 15, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edenhaus edenhaus edenhaus approved these changes

Assignees
No one assigned
Labels
pr: new-feature PR, which adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MVladislav @edenhaus