Add Docker attestation and provenance #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkuegler
force-pushed
the
feature/docker-scout-fixes
branch
from
c19920e
to
84f704d
Compare
- change user to nonroot - add the BUILDKIT_SBOM_SCAN_CONTEXT buildarg for proper SBOM creation Docker/build.py - add provenance - add sbom attestation - some formattíng
- add FREESURFER_URL build-arg and pass the URL to install_fs_pruned.sh Docker/install_fs_pruned.sh - add option to download FreeSurfer froma different URL - optimize upx option for multiple threads - reorder so upx runs before link are created Docker/build.py - add --attest argument - change building logic, so it works with docker-container - add attestation logic
dkuegler
force-pushed
the
feature/docker-scout-fixes
branch
from
84f704d
to
9123515
Compare
|
I hope this finally works.... unfortunately, the attestation changes mean that people that want to do attestation, need to change a couple of things, such as:
but the basic build should still work without that, just attestation are a bit weird :(. |
|
please add some documentation to readme, including attestation requirements. |
|
Documentation added to Docker/README.md and an additional option that does not require containerd, but a local registry. Unfortunately, the sbom is incomplete as most the version of Freesurfer as well as Fastsurfer are not included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile
This is so the FastSurfer docker image satisfies docker scout criteria.
At this point, it might be necessary to check whether the user inside the docker container is manually entered, or otherwise weird things happen (similar to our --allow-root flag).
I will look into that.