Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOp For Sphinx Documentation #451

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Conversation

engrosamaali91
Copy link
Contributor

The branch DevOp has been rebased on dev branch.

Steps followed:

  1. git checkout dev
  2. git pull upstream dev
  3. git checkout DevOp
  4. git rebase dev
  5. git push origin DevOp --force

@engrosamaali91 engrosamaali91 marked this pull request as draft February 7, 2024 14:03
Copy link
Member

@dkuegler dkuegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at files up to but not including FastSurferCNN/utils/mapper.py

FastSurferCNN/data_loader/data_utils.py Outdated Show resolved Hide resolved
FastSurferCNN/data_loader/data_utils.py Outdated Show resolved Hide resolved
FastSurferCNN/data_loader/dataset.py Outdated Show resolved Hide resolved
FastSurferCNN/data_loader/dataset.py Show resolved Hide resolved
FastSurferCNN/generate_hdf5.py Outdated Show resolved Hide resolved
FastSurferCNN/utils/common.py Outdated Show resolved Hide resolved
FastSurferCNN/utils/common.py Outdated Show resolved Hide resolved
FastSurferCNN/utils/common.py Outdated Show resolved Hide resolved
FastSurferCNN/utils/common.py Outdated Show resolved Hide resolved
FastSurferCNN/utils/common.py Outdated Show resolved Hide resolved
Copy link
Member

@dkuegler dkuegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes after rebase

doc/api/FastSurferCNN.utils.rst Outdated Show resolved Hide resolved
doc/api/index.rst Outdated Show resolved Hide resolved
arg_types.py
- update unquote_str docstring

common.py
- remove the obsolete removesuffix function

run_prediction.py
- remove the obsolete removesuffix function

quick_qc.py
- Fix the docstring of get_region_by_intersection_mask

generate_hdf5.py
- replace seg-mask with sag_mask

interpolation_layer.py
- Update of the crop_position property

common.py
- Update the docstrings of pipeline and iterate
@engrosamaali91 engrosamaali91 marked this pull request as ready for review February 8, 2024 16:40
@engrosamaali91 engrosamaali91 marked this pull request as draft February 8, 2024 16:41
@dkuegler dkuegler marked this pull request as ready for review February 8, 2024 16:43
@m-reuter m-reuter merged commit 8c20cca into Deep-MI:dev Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants