Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LaPy Test Cases #43

Merged
merged 16 commits into from
Oct 26, 2023
Merged

LaPy Test Cases #43

merged 16 commits into from
Oct 26, 2023

Conversation

engrosamaali91
Copy link
Contributor

No description provided.

@engrosamaali91
Copy link
Contributor Author

In this commit de75fc1 a test file and expected_outcomes.json files have been removed from lapy directory.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #43 (852f29a) into main (8ce8a7a) will increase coverage by 23.32%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            main      #43       +/-   ##
==========================================
+ Coverage   6.43%   29.76%   +23.32%     
==========================================
  Files         14       14               
  Lines       2362     2362               
  Branches     301      301               
==========================================
+ Hits         152      703      +551     
+ Misses      2207     1602      -605     
- Partials       3       57       +54     
Flag Coverage Δ
unittests 29.76% <100.00%> (+23.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
lapy/tria_mesh.py 54.76% <100.00%> (+44.78%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@engrosamaali91 engrosamaali91 marked this pull request as draft October 25, 2023 10:22
@engrosamaali91
Copy link
Contributor Author

Hello, All checks have passed for committed tests 3bc26d3, removing the flag from work in progress.
For remaining tests i.e visualization and Triamesh_Geodesics only I would like to create a new branch and a new PR.

@engrosamaali91 engrosamaali91 marked this pull request as ready for review October 26, 2023 10:20
@m-reuter
Copy link
Member

I think the Laplase typo is still not fixed? Also there is some code in the test scripts that is not part of any test functions?

@engrosamaali91
Copy link
Contributor Author

I think the Laplase typo is still not fixed? Also there is some code in the test scripts that is not part of any test functions?

In this commit 49a96e4 I have adjusted the code with test functions, the code was still part of the test functions and it was computing variables globally.

Now it is directly being computed from functions itself.

Laplase typo is fixed.

@m-reuter m-reuter merged commit 1d91511 into Deep-MI:main Oct 26, 2023
@engrosamaali91 engrosamaali91 deleted the test_cases branch October 26, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants