Fix Make PWMMotorMediator physically realistic #88.
#102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix #100 (use DBSBrake to ensure unique name).
…llerTest-realistic
Run CI on macos-13 instead of macos-14 in hopes that it will be faster.
CoolSpy3
requested changes
Jul 9, 2024
tests/src/systemTest/java/frc/robot/PWMMotorControllerTest.java
Outdated
Show resolved
Hide resolved
tests/src/systemTest/java/frc/robot/PWMMotorControllerTest.java
Outdated
Show resolved
Hide resolved
...in/controller/src/main/java/org/carlmontrobotics/deepbluesim/mediators/PWMMotorMediator.java
Outdated
Show resolved
Hide resolved
...in/controller/src/main/java/org/carlmontrobotics/deepbluesim/mediators/PWMMotorMediator.java
Outdated
Show resolved
Hide resolved
tests/src/systemTest/java/frc/robot/PWMMotorControllerTest.java
Outdated
Show resolved
Hide resolved
tests/src/systemTest/java/frc/robot/PWMMotorControllerTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: CoolSpy3 <55305038+CoolSpy3@users.noreply.github.com>
…istic' into make-PWMMotorControllerTest-realistic
|
@CoolSpy3, I think with my latest commit, I finally have the math correct in both the test and the implementation. |
…retical one,. This should be less flaky since we make the measurements well after the robot code changes the desired speed.
… 1 by using updated math.
CoolSpy3
reviewed
Jul 10, 2024
tests/src/systemTest/java/frc/robot/PWMMotorControllerTest.java
Outdated
Show resolved
Hide resolved
tests/src/systemTest/java/frc/robot/PWMMotorControllerTest.java
Outdated
Show resolved
Hide resolved
CoolSpy3
requested changes
Jul 10, 2024
Co-authored-by: CoolSpy3 <55305038+CoolSpy3@users.noreply.github.com>
Co-authored-by: CoolSpy3 <55305038+CoolSpy3@users.noreply.github.com>
CoolSpy3
approved these changes
Jul 10, 2024
Formatting fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix #100 (use DBSBrake to ensure unique name).