-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: save preprocessed data into one .hdf5 file as default #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniBodor
approved these changes
Nov 23, 2022
DaniBodor
reviewed
Nov 23, 2022
…ss_func refactor: move preprocess function to QueryDataset class and rename
DaniBodor
reviewed
Nov 23, 2022
DaniBodor
reviewed
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the preprocessed data are saved into one hdf5 as default. The user can always decide to keep them in separated files using
combine_files
parameter inpreprocess
function.This is the current order of arguments in
preprocess
:Now the user can fill in the arguments like this:
preprocess(queries, prefix)
in the default case (that is supposed to be the most used one, especially when starting using the package; the possibility to select only some features from the beginning should be used by "expert" users that already have lots of insights on the features themselves). So if we put it in a position different from the last ones --same applies tocombine_files
-- , then it will be always needed to specify the arguments like this:preprocess(queries=queries, prefix=prefix)
.But we can think about changing such order @DaniBodor