-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: data generation threading locked #330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Actually this is still not solved. I think the issue has been introduced with PR #274. The problem is that trying to process ~100k queries (on Snellius), at a certain point the process get stuck, and no more data points are appended to the hdf5 files. No error message is displayed and this makes highly difficult to isolate the problem. The error I was getting before modifying the code as in this PR was To reproduce: run 3D-Vac/src/3_build_db4/GNN/1_generate_features.py changing Models IDs that gave detected problems: BA-115668, BA-132474, BA-503344, BA-65401. Exception raised type: 'KeyError'. This shouldn't be the problem though, since we catch the exception and the code should go on running. |
In the deeprank code, the 'Chain' class does have an attribute '_model'. So I really don't understand where this error comes from. I cannot reproduce this error, since I don't have the data file 'BA_pMHCI_human_quantitative_only_eq.csv'. Possibly I need other files to reproduce the error too. |
sent via slack |
Thanks! But it seems I also need pdb files and other files. Right now it prints:
|
OK, probably be best to wait for @gcroci2 then. She'll be back in office tomorrow. |
You need to run the script on Snellius, then all the files are already in there (thay refer to Snellius |
process
method
The issue was one single data point (BA-248433) that was causing I've handled it by using |
One exception (
AttributeError
) wasn't catched and the entire process was blocked. Now we catch all exceptions.