Regenerate class diagrams #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcroci2
added
docs
DaniBodor
approved these changes
Nov 6, 2023
|
The links are not working for me. |
Now I embedded the umls as svgs images. @FarzanehParizi @DaniBodor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generated new diagrams using https://www.gituml.com/, separating them in two: one for the data processing phase, and another one for the ML pipeline (training + testing + export).
I also deleted the .sh file we had to generate class diagrams. gituml.com is much more intuitive and convenient, it's interactive if we wish to edit some of the classes from the diagram, and stores the generated diagrams permanently on Amazon AWS.
Even if PR #492 and #515 are not merged yet, I used those branches for generating the new class diagrams.