Adapting ruff #563
Merged
Adapting ruff #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
was defaulted to prettier, but it doesn't work for shell scripts
DaniBodor
force-pushed
the
541b_ruff_changes_dbodor
branch
3 times, most recently
from
3f978f3 to
146bfa7
Compare
DaniBodor
force-pushed
the
541b_ruff_changes_dbodor
branch
from
146bfa7 to
38334ad
Compare
individually suppressed those that are unwanted/unrealistic instead of acvtivating each module explicitly also imporove some annotations in pyproject.toml
removed or sent to logger or to warning (or suppressed)
the full ruff documentation can be accessed by hovering over the suppressed linting rule
DaniBodor
force-pushed
the
541b_ruff_changes_dbodor
branch
from
38334ad to
dfb0d74
Compare
- Moved docstrings from __init__ to the class level instead - Added missing docstrings or suppressed the call for them - Did not activate missing docstring in public method because there are too many missing - Deactivated missing docsstrings in tests
DaniBodor
force-pushed
the
541b_ruff_changes_dbodor
branch
from
dfb0d74 to
3cf9dd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Activated and fixed more settings.
@gcroci2 , I think most of these you can just glance over, but can you please check what I did in 35248b9. This was where I dealt with print statements in the code base, either by:
Can you check whether you agree with what I did where.