-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add action for releasing new docker image and testing it #640
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to have an automated up-date docker image ready to go at all times. Lots of work has gone into this, but I think it was worth it.
There are a few merge conflicts. I think due to the notebook changes. Hopefully easy to solve.
Few questions:
- I have not tested the new install instructions yet. Are these something I can test already, or only after the workflow has triggered at least once?
- Has the new workflow/changes to existing workflows been tested? If not, is there any way to do so before merging (without having to make a fork and release that on PyPi as well)?
During the development I tested them on this branch (by changing the settings in the yml workflow), but as it is now it can't be directly tested. I plan to do a new release as soon as this PR is merged so we can be sure it all works fine, and worst case I'll open immediately a new issue.
There is no straightforward way. I'll try now to solve the merge conflicts paying attention, but then we will know for sure only with the first real release will be triggered. |
Commits are too messy to be considered, here I summarized what I did:
release.yml
file now contains also the publication of an updated docker image on GitHub Packages, that happens only when a new package release is published on PyPI. Both the release number and thelatest
tags are assigned to the newly published image.test-docker-image.yml
file runs tests in the latest deployed image. This workflow gets triggered only when a complete release (PyPI + image on GitHub Packages) succeeds.Once this PR is merged, we need to do a new release in order to actually publish a correct version of the image. Then we will need to delete the version I published now, that had only testing purposes. I tested the new workflows during the development of the PR and everything should work as exected, but we will know for sure only when a new package release will be published.