-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update read and write #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks nice but it breaks all the tests. So we have to fix that before merging !
line += '\n' | ||
|
||
f.write(line) | ||
|
||
# close | ||
f.close() | ||
|
||
def _format_atomname(self, data): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's nice and controlled but is it needed to read the data ? But at least to write it I think it's really useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the input PDB has strict format, so we don't it that for reading. But we do need some code to preprocess PDB files, I'll write it later.
only the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should fix the sqlalchemy test before merging
Maybe it's as easy as using a proper pdb ...
Actually there are two bugs in pdb2sqlAlchemy.py. Fixed. |
Updates: