Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(issues): add support for exporting issues to JSON #102

Merged
merged 5 commits into from
Feb 17, 2022
Merged

feat(issues): add support for exporting issues to JSON #102

merged 5 commits into from
Feb 17, 2022

Conversation

burntcarrot
Copy link
Contributor

  • add --json flag
  • add --output flag
  • add custom types for marshaling to JSON
  • add helper utilities for JSON conversion

Signed-off-by: burntcarrot aadhav.n1@gmail.com

@burntcarrot
feat(issues): add support for exporting issues to JSON
d7389d3 
* add --json flag
* add --output flag
* add custom types for marshaling to JSON
* add helper utilities for JSON conversion

Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
@cla-bot cla-bot bot added the cla-signed label Feb 17, 2022
@burntcarrot
refactor(issues): rename output flag
f314a98 
Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
@burntcarrot
refactor(issues): update comments
bba5ead 
Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
siddhant-deepsource
siddhant-deepsource suggested changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@siddhant-deepsource siddhant-deepsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and almost ready. Have made some comments though and requested some changes. Please take a look and address them. Also, let me know in case you have any doubts/queries regarding them.

command/issues/list/list.go Outdated Show resolved Hide resolved
command/issues/list/list.go Outdated Show resolved Hide resolved
command/issues/list/list.go Outdated Show resolved Hide resolved
command/issues/list/list.go Show resolved Hide resolved
command/issues/list/list.go Outdated Show resolved Hide resolved
command/issues/list/list.go Outdated Show resolved Hide resolved
command/issues/list/list.go Outdated Show resolved Hide resolved
command/issues/list/list.go Outdated Show resolved Hide resolved
command/issues/list/list.go Outdated Show resolved Hide resolved
deepsource/issues/issues_list.go Outdated Show resolved Hide resolved
@burntcarrot
refactor(issues): extract types and update command descriptions
26b4428 
Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
@burntcarrot
refactor(issues): update variable declaration
18fe410 
Signed-off-by: burntcarrot <aadhav.n1@gmail.com>
@siddhant-deepsource siddhant-deepsource merged commit 41d1cb9 into DeepSourceCorp:master Feb 17, 2022
@burntcarrot burntcarrot deleted the json-export branch February 17, 2022 16:35
This was referenced Feb 17, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourya-deepsource sourya-deepsource Awaiting requested review from sourya-deepsource sourya-deepsource is a code owner

@siddhant-deepsource siddhant-deepsource Awaiting requested review from siddhant-deepsource

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@burntcarrot @siddhant-deepsource