Add logic for key validation in report subcommand #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Subham Sarkar <subhamsarkar@DeepSource-C02DRL12ML7H.local>
LAE-7238 CLI: Raise an error if the `--key` parameter is not a valid language
A user was sending Prevent the user from sending a bad value as key, and give a much better error message in the CLI: |
subham-deepsource
requested review from
siddhant-deepsource,
anto-deepsource and
tushar-deepsource
Signed-off-by: Subham Sarkar <subham@deepsource.io>
Signed-off-by: Subham Sarkar <subham@deepsource.io>
Signed-off-by: Subham Sarkar <subham@deepsource.io>
Signed-off-by: Subham Sarkar <subham@deepsource.io>
Signed-off-by: Subham Sarkar <subham@deepsource.io>
|
To make the tests pass, I think we have to update the DSN. @siddhant-deepsource Right? |
|
Its the issue with using the test coverage github action. Ref: https://discuss.deepsource.io/t/breaking-deepsource-test-coverage-github-action/507 |
anto-deepsource
requested changes
Mar 1, 2023
Signed-off-by: Tushar Sadhwani <86737547+tushar-deepsource@users.noreply.github.com>
Signed-off-by: Tushar Sadhwani <86737547+tushar-deepsource@users.noreply.github.com>
|
CI is fixed now. |
Signed-off-by: Tushar Sadhwani <86737547+tushar-deepsource@users.noreply.github.com>
anto-deepsource
previously approved these changes
Mar 2, 2023
sourya-deepsource
requested changes
Mar 2, 2023
Signed-off-by: Subham Sarkar <subham@deepsource.io>
sourya-deepsource
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the wrong value is passed to
--keyindeepsource report, it would send it to the backend and return a cryptic error message.This ensures that you pass a supported language to
--key.