fix: Warn users when GitHub Actions is making a merge commit #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes: - Change signature of `gitGetHead` to return a warning for GitHub Actions merge commits - Propagate the warning to `report` command response
Resolved issues in command/report/report.go with DeepSource Autofix
Signed-off-by: Siddhant N Trivedi <siddhant@deepsource.io>
Pass the head commit picked up from context as an env variable. This would be picked up by the report command, and no git logic would need to be executed.
| // before this is checked. Since this is guaranteed to be set if artifact is sent using our GitHub action, | ||
| // we can reliably send the commit SHA, and no git commands are executed, making the actions work all the time. \o/ | ||
|
|
||
| // We are setting PR's head commit as default using github context as env variable: "GHA_HEAD_COMMIT_SHA" |
There was a problem hiding this comment.
sourya-deepsource
requested changes
Aug 24, 2023
Signed-off-by: Sourya Vatsyayan <sourya@deepsource.io>
sourya-deepsource
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes:
gitGetHeadto return a warning for GitHub Actions merge commitsreportcommand response